[libcxx-commits] [PATCH] D102468: [libcxx][ranges] makes `basic_string_view` and `span` satisfy concept view

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

What part of the LWG issue are we missing? Is it only the `split_view` part? If so, I think it's fine to mark it as done since it'll be handled when we implement `split_view` (http://eel.is/c++draft/range.split.view has the LWG issue applied).



================
Comment at: libcxx/test/std/containers/views/range_concept_conformance.compile.pass.cpp:26
 static_assert(stdr::random_access_range<range>);
-static_assert(!stdr::view<range>);
+static_assert(stdr::view<range>&& stdr::enable_view<range>);
 static_assert(stdr::sized_range<range>);
----------------
Missing space between `>` and `&&` (elsewhere too).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102468/new/

https://reviews.llvm.org/D102468