[libcxx-commits] [PATCH] D98207: [SystemZ][z/OS] Missing wchar functions libc++

Daniel McIntosh via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 9 12:03:33 PDT 2021


DanielMcIntosh-IBM added inline comments.


================
Comment at: libcxx/src/support/ibm/wcsnrtombs.cpp:53
+              dest_remaining -= char_size;
+          dest_converted += char_size;
+          continue;
----------------
DanielMcIntosh-IBM wrote:
> Since dst is a pointer and not a pointer-to-a-pointer, wouldn't it be easier to just add `char_size` directly to `dst` and do away with `dest_converted`? You don't even need to add an extra `if (dst)` since you have one on line 51
Never mind this part, I forgot we return `dest_converted`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98207/new/

https://reviews.llvm.org/D98207



More information about the libcxx-commits mailing list