[libcxx-commits] [PATCH] D102798: [SystemZ][z/OS] XFAIL aligned allocation tests on z/OS

[Zibi Sarbino via Phabricator via libcxx-commits]

zibi added inline comments.


================
Comment at: libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp:23
 // XFAIL: use_system_cxx_lib && x86_64-apple-macosx10.9
+// XFAIL: -zos
 
----------------
ldionne wrote:
> What is the `-zos` Lit feature? Is this using Lit's partial matching of triples?
> 
> This looks incorrect to me, since you only want to mark this as XFAIL when running against your system library (well, that or libc++ when configured as-if it were your system library).
Daniel, I think we want to use target-zos. You might want to wait until this is available upstream.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102798/new/

https://reviews.llvm.org/D102798