[libcxx-commits] [PATCH] D103973: [libc++abi] Remove the LIBCXXABI_ENABLE_PIC option

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a reviewer: sbc100.
ldionne added a subscriber: sbc100.
ldionne added a comment.

Note that this option was added in https://reviews.llvm.org/D60049.

I was at most lukewarm about adding it but we still did, because there seemed to be a use case. @phosek just asked me why libc++abi was defining its own knob for enabling PIC, which led me to reconsider D60049 <https://reviews.llvm.org/D60049> and to this patch.

@sbc100 Is there no way you can get by with setting `CMAKE_POSITION_INDEPENDENT_CODE` instead? In D60049 <https://reviews.llvm.org/D60049> you mention that it's going to impact all the other LLVM components you're building, but perhaps that is reasonable? Also, if you're building a toolchain, you should be using the Runtimes build. I don't know whether you are, however if so, it should be possible to specify that option only when building the runtimes, not the tools themselves (and if that's not possible, then we should make it possible cause I think it's a valid and useful thing to have).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103973/new/

https://reviews.llvm.org/D103973