[libcxx-commits] [PATCH] D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization")

Wed Jun 9 09:29:50 PDT 2021

jroelofs added inline comments.

================
Comment at: libcxx/test/std/atomics/atomics.types.generic/address.pass.cpp:10
 // UNSUPPORTED: libcpp-has-no-threads
 //  ... test case crashes clang.
+// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
----------------
Quuxplusone wrote:
> I know line 10 is a pre-existing comment, but it makes no sense to me. Looks like 5 comments just like this were added by @jroelofs in b3fcc67f8f13cd95d36ed29d0ae1308decb9e099 (D3969) back in 2014. I propose that someone should delete these comments. Could even be in this PR, since you are having to touch all 5 of these test files already.
Now I'm kicking myself for not having filed bugzilla's for them. Oops.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103769/new/

https://reviews.llvm.org/D103769