[libcxx-commits] [PATCH] D102119: [libcxx][optional] adds missing constexpr operations

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

A few comments, and also CI should pass.



================
Comment at: libcxx/docs/Cxx2bStatus.rst:42
+
+  .. [#note-P2231] P2231: Implemented ahead of time and backported to C++20, so as to not block C++20 ranges.
+
----------------
I don't think this note is useful anymore.


================
Comment at: libcxx/test/std/utilities/optional/optional.object/optional.object.assign/emplace_initializer_list.pass.cpp:101
+        check_X();
+        static_assert(check_X());
     }
----------------
`#if TEST_STD_VER > 17` ? (here and below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102119/new/

https://reviews.llvm.org/D102119