[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Is this configuration being tested by a bot? Who is it important for?

This looks good to me, except for the principle that we should not attempt to half-support configurations that we don't commit to testing - instead we should clearly state that those are not supported and simplify the library to not even try to support them. I'm 100% fine with this patch and supportive of this if I can get an answer to the questions above.

I'm hitting on that nail again because I happened to be looking at some CMake complexity yesterday that was introduced by attempting to port libc++ to Windows a few years back. I wasn't sure what the status was and whether it was still necessary (I suspect not), but it did prevent me from making simplifications to the code. I'm trying to prevent these situations where we feel blocked from making improvements to avoid breaking <some configuration>, without knowing whether it actually even matters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947