[libcxx-commits] [PATCH] D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong, weak}.

Tue Jun 8 09:59:48 PDT 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Is it possible to write a test for that? When you say

> This was caught by tsan tests after D99434 <https://reviews.llvm.org/D99434> [...]

Do you mean that any Clang that includes the fix for D99434 <https://reviews.llvm.org/D99434> will catch the error with the existing libc++ test suite when TSAN is enabled? If so, then I think it's fine not to add a test, since it's already tested. We could consider moving more CI configurations to Clang trunk, too.

Requesting changes until I have answers to my questions, but otherwise this LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103846/new/

https://reviews.llvm.org/D103846