[libcxx-commits] [PATCH] D103734: [libcxx] moves <utility> content out of <type_traits> and into their own headers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 8 06:49:49 PDT 2021


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I'd like to better understand the motivation for this patch - are you working towards something specific? Generally LGTM.



================
Comment at: libcxx/include/__decay_copy.h:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
Why is this at the top level?


================
Comment at: libcxx/test/std/utilities/utility/utility.swap/swap_array.pass.cpp:17
+#include <algorithm>
 #include <cassert>
 #include <memory>
----------------
This is using `is_same`, so it needs `<type_traits>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103734/new/

https://reviews.llvm.org/D103734



More information about the libcxx-commits mailing list