[libcxx-commits] [PATCH] D103863: [libcxx][ci] enables assertions for runtimes-build

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 7 23:09:15 PDT 2021


Mordante accepted this revision as: Mordante.
Mordante added a comment.

The change is fine by me, but I've some concerns with the build node used for this feature.
The Apple nodes aren't the fastest neither the most reliable build nodes we have.
This combination makes this node less than ideal for build iterations.
So I'm not happy to _only_ enable it for this node, but the improvements can be done in a separate patch.

@ldionne how do our Linux build nodes get their clang version and would it be easy to turn on the assertions for them? 
Alternatively would it make sense to have one Linux node build clang HEAD with assertions to test C++2b?
I assume in the future would be nice to have a clang HEAD when we need compiler features to implement C++2b library features.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103863/new/

https://reviews.llvm.org/D103863



More information about the libcxx-commits mailing list