[libcxx-commits] [PATCH] D103551: [libcxx][module-map] creates submodules for private headers

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

In D103551#2801442 <https://reviews.llvm.org/D103551#2801442>, @phosek wrote:

> After this change landed, we started seeing a number of crashes in our CI when using the just built Clang to run libc++ tests (that is using the runtimes build):
>
>   Failed Tests (6):
>     libc++ :: libcxx/modules/cinttypes_exports.compile.pass.cpp
>     libc++ :: libcxx/modules/clocale_exports.compile.pass.cpp
>     libc++ :: libcxx/modules/cstdint_exports.compile.pass.cpp
>     libc++ :: libcxx/modules/inttypes_h_exports.compile.pass.cpp
>     libc++ :: libcxx/modules/stdint_h_exports.compile.pass.cpp
>     libc++ :: libcxx/modules/stds_include.sh.cpp
>
> They all fail with the same error:
>
>   clang++: clang/lib/Serialization/ASTWriter.cpp:2502: unsigned int clang::ASTWriter::getSubmoduleID(clang::Module *): Assertion `(ID || !Mod) && "asked for module ID for non-local, non-imported module"' failed.
>   clang++: llvm/include/llvm/Bitstream/BitstreamWriter.h:124: llvm::BitstreamWriter::~BitstreamWriter(): Assertion `BlockScope.empty() && CurAbbrevs.empty() && "Block imbalance"' failed.
>   clang-13: error: clang frontend command failed with exit code 134 (use -v to see invocation)

Interesting. Our scheduled Runtimes build is passing, so I don't know what's up there. Could you please link to one of the failing builds? I'd like to read the diagnostics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103551/new/

https://reviews.llvm.org/D103551