[libcxx-commits] [PATCH] D103705: [libc++] Simplify a few macros in __config

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 4 11:32:55 PDT 2021


phosek added inline comments.


================
Comment at: libcxx/include/__config:1300
-#ifndef _LIBCPP_THREAD_SAFETY_ANNOTATION
-#  ifdef _LIBCPP_HAS_THREAD_SAFETY_ANNOTATIONS
-#    define _LIBCPP_THREAD_SAFETY_ANNOTATION(x) __attribute__((x))
----------------
ldionne wrote:
> This looks like a bug to me, but I'm not sure who added those thread safety annotations or when they are used. @phosek I have a feeling I've seen you touch those at some point?
I added some thread annotations but this predates me, I agree that this looks like a bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103705/new/

https://reviews.llvm.org/D103705



More information about the libcxx-commits mailing list