[libcxx-commits] [PATCH] D103444: [libcxx] Don't use an undefined '+' in unsigned/octal/hexal print formats

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D103444#2792065 <https://reviews.llvm.org/D103444#2792065>, @mstorsjo wrote:

> In D103444#2791182 <https://reviews.llvm.org/D103444#2791182>, @Mordante wrote:
>
>> SMGT, but I'd like some unit tests to test the new correct behaviour.
>
> Hmm, so a test under libcxx/test/libcxx somewhere, with a local class subclassing `std::__1::__num_put_base` so that the protected method `__format_int` can be called, and then testing the different flag combinations?

Hmm I see testing this isn't that trivial. In that case I'd rather see a buildbot as suggested on Discord. But that's out of the scope of this patch.
LGTM, modulo @Quuxplusone's parenthesize request.
It looks like the build failures aren't caused by this patch, but keep an eye out after landing this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103444/new/

https://reviews.llvm.org/D103444