[libcxx-commits] [PATCH] D102028: [libcxx][ranges] Implement views::all.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Implementation LGTM, seems like we can improve tests to some degree (my comment but also Arthur's comment which doesn't appear to have been addressed yet).



================
Comment at: libcxx/test/std/ranges/range.adaptors/range.all.pass.cpp:85
+
+constexpr bool test() {
+  {
----------------
We seem to be missing tests for `noexcept`-ness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102028/new/

https://reviews.llvm.org/D102028