[libcxx-commits] [PATCH] D103558: Remove VLA from libcxx locale header

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

> Note that, while the base prefix for hex (0x) is slightly longer than the
> base prefix for octal (0), this isn't a concern. The difference in the space
> needed for the value portion of the string is enough to make up for this.

I'm also not concerned since that's the same behaviour as before.

Thanks for the cleanup, LGTM.
I see a lot of build failure on Runtime build node, I assume it's already fixed by D103533 <https://reviews.llvm.org/D103533>. Can you rebase to verify your patch to verify that indeed solve all issues with this patch on that node?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103558/new/

https://reviews.llvm.org/D103558