[libcxx-commits] [PATCH] D103533: [libc++] Remove unused variable

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 2 15:37:00 PDT 2021


ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/test/std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.bin/eval.pass.cpp:207-208
     assert(var == x_var);
 //    assert(skew == x_skew);
 //    assert(kurtosis == x_kurtosis);
 }
----------------
Quuxplusone wrote:
> Shouldn't you just comment these lines back in, so that the variables end up getting used/tested?
> Line 197's comment is relevant, though.
I tested with ubsan enabled and I'm not seeing any issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103533/new/

https://reviews.llvm.org/D103533



More information about the libcxx-commits mailing list