[libcxx-commits] [PATCH] D103551: [libcxx][module-map] creates submodules for private headers

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

In D103551#2794554 <https://reviews.llvm.org/D103551#2794554>, @Quuxplusone wrote:

> Seems surprisingly painless.
> You did miss the other "libc++ classic style" helper headers, e.g. `__functional_03`; did you want to get those in this same PR?

Done for all but `__functional_(base_)?03` since they're designed to be textual includes.
I think adjusting those deserves its own patch.



================
Comment at: libcxx/include/module.modulemap:303
   }
   module format {
     header "format"
----------------
Quuxplusone wrote:
> `requires cplusplus20`? or what's the rationale for adding that on various headers?
> E.g. I see `<latch>` is marked with `requires cplusplus14`, even though it's also new-in-C++20.
Nice catch. For latch specifically, see D68480. Looks like libc++ supports it from C++14 onward.


================
Comment at: libcxx/include/module.modulemap:469-476
+      module access                 { header "__ranges/access.h"                 }
+      module concepts               { header "__ranges/concepts.h"               }
+      module data                   { header "__ranges/data.h"                   }
+      module empty                  { header "__ranges/empty.h"                  }
+      module enabled_borrowed_range { header "__ranges/enabled_borrowed_range.h" }
+      module size                   { header "__ranges/size.h"                   }
+      module view_interface         { header "__ranges/view_interface.h"         }
----------------
Quuxplusone wrote:
> I like this one-line-per-header formatting. Please also use it for `__utility` and `__format` and `__algorithm`.
Thanks, didn't notice I missed a few.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103551/new/

https://reviews.llvm.org/D103551