[libcxx-commits] [PATCH] D103533: [libc++] Remove unused variable

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.bin/eval.pass.cpp:187-188
         var += d2;
         skew += dbl * d2;
         kurtosis += d2 * d2;
     }
----------------
Well, that's not going to work. ;)


================
Comment at: libcxx/test/std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.bin/eval.pass.cpp:207-208
     assert(var == x_var);
 //    assert(skew == x_skew);
 //    assert(kurtosis == x_kurtosis);
 }
----------------
Shouldn't you just comment these lines back in, so that the variables end up getting used/tested?
Line 197's comment is relevant, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103533/new/

https://reviews.llvm.org/D103533