[libcxx-commits] [PATCH] D103551: [libcxx][module-map] creates submodules for private headers

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 2 12:53:26 PDT 2021


cjdb created this revision.
cjdb added reviewers: EricWF, rsmith, jyknight, ldionne.
cjdb requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Most of our private headers need to be treated as submodules so that
Clang modules can export things correctly. Previous commits that split
monolithic headers into smaller chunks were unaware of this requirement,
and so this is being addressed in one fell swoop. Moving forward, most
new headers will need to have their own submodule (anything that's
conditionally included is exempt from this rule, which means `__support`
headers aren't made into submodules).

This hasn't been marked NFC, since I'm not 100% sure that's the case.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103551

Files:
  libcxx/include/__iterator/advance.h
  libcxx/include/__iterator/indirect_concepts.h
  libcxx/include/__iterator/next.h
  libcxx/include/__iterator/prev.h
  libcxx/include/__memory/allocation_guard.h
  libcxx/include/__memory/allocator.h
  libcxx/include/__memory/allocator_traits.h
  libcxx/include/__memory/pointer_safety.h
  libcxx/include/__memory/pointer_traits.h
  libcxx/include/module.modulemap

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103551.349355.patch
Type: text/x-patch
Size: 9087 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210602/38a13308/attachment.bin>


More information about the libcxx-commits mailing list