[libcxx-commits] [PATCH] D103416: [libc++] Fix result-type and value_type computation in <valarray>.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 1 19:05:13 PDT 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I Discord'ed you about it, but let's talk about this here. I fail to see where the tests would fail if we still had the bug you're fixing. Please explain, but LGTM assuming there's an explanation :-). Thanks for correcting this long-standing issue with a not very glamorous type -- those corners are still important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103416/new/

https://reviews.llvm.org/D103416



More information about the libcxx-commits mailing list