[libcxx-commits] [PATCH] D103487: [libcxx][ranges] Add `default_sentinel` and `default_sentinel_t`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

LGTM post commit.



================
Comment at: libcxx/test/std/iterators/predef.iterators/default.sentinel/default.sentinel.pass.cpp:16
+
+#include <iterator>
+
----------------
Quuxplusone wrote:
> ```
> #include <concepts>
> #include <type_traits>
> ```
> Actually, if you replaced `same_as` with `is_same_v` and `semiregular` with `is_copy_constructible_v`, could you remove the `UNSUPPORTED: libcpp-no-concepts` line so that this would be testable in more situations?
> If de-concept-ifying this test turns into a rabbit hole, then never mind; but if it's trivial to simplify, then it'd be nice.
FWIW, `libcpp-no-concepts` is something that will die eventually as we move to newer compilers. IMO there's little benefit in doing any work to improve the situation on compilers that do not support concepts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103487/new/

https://reviews.llvm.org/D103487