[libcxx-commits] [PATCH] D103493: [libcxx][ranges] Add concepts in range.utility.helpers.

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 1 16:40:04 PDT 2021


cjdb accepted this revision.
cjdb added a comment.

LGTM



================
Comment at: libcxx/test/libcxx/ranges/range.utility.helpers/simple_view.compile.pass.cpp:35-38
+  struct sentinel {
+    friend bool operator==(int*, sentinel const&);
+    friend bool operator==(sentinel const&, int*);
+  };
----------------
This type isn't necessary: `test_iterators.h` has a `sentinel_wrapper` vocabulary test type that we can use instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103493/new/

https://reviews.llvm.org/D103493



More information about the libcxx-commits mailing list