[libcxx-commits] [PATCH] D103478: [libc++][compare] Implement three_way_comparable[_with] concepts

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb requested changes to this revision.
cjdb added a comment.
This revision now requires changes to proceed.

Thanks for working on this. To get an LGTM, please add test types for the following:

- A type where `operator<=>` isn't declared.
- A type where `operator<=>` is deleted.
- A type where `operator<=>` is declared and `operator==` isn't.
- A type where `operator==` is deleted.
- A type where all the inequality operators are defined.
- A type where all but one of the inequality operators are declared.
- A type where all but one of the inequality operators are declared, and the missing one is deleted.

PTAL at the `totally_ordered` and `totally_ordered_with` tests for inspiration.



================
Comment at: libcxx/test/libcxx/inclusions/utility.inclusions.compile.pass.cpp:25-27
+// FIXME (rarutyun): enable this test part when cyclic dependency for
+// <compare> header is resolved
+//  #   error "<utility> should include <compare> in C++20 and later"
----------------
Please fix this before merging (same as above).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103478/new/

https://reviews.llvm.org/D103478