[libcxx-commits] [PATCH] D101737: [libcxx] Implement view.interface.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM, but please wait for CI to finish.

(Also, we just spoke offline and you mentioned you needed to update the Status paper and the synopsis - please do it before landing).



================
Comment at: libcxx/include/__ranges/view_interface.h:55
+
+  template<class _D2 = _Derived>
+  [[nodiscard]] constexpr bool empty() const
----------------
CaseyCarter wrote:
> ldionne wrote:
> > Why is that necessary? Is that the workaround for `gcc -fconcepts` you're discussing in the comments below?
> This is necessary to workaround https://bugs.llvm.org/show_bug.cgi?id=44833.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101737/new/

https://reviews.llvm.org/D101737