[libcxx-commits] [PATCH] D107098: [libc++] Implement the underlying mechanism for range adaptors

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver accepted this revision.
zoecarver added a comment.
This revision is now accepted and ready to land.

This implementation looks good to me. It's actually pretty simple, and I don't think we can shave anything else off. I have a few suggestions:

1. Use `_LIBCPP_EXPRESSION_EQUIVALENT` in `range_adaptors.h`
2. I want to see some more tests, specifically something like what I posted for the inline namespace example.
3. And as we talked about, splitting this into separate patches would be great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107098/new/

https://reviews.llvm.org/D107098