[libcxx-commits] [PATCH] D103368: [libc++][format] Adds parser std-format-spec.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 30 01:27:24 PDT 2021


Mordante updated this revision to Diff 362991.
Mordante added a comment.

- Rebased and updated to work against main.
- Remove `[[nodiscard]]`s.
- s/_LIBCPP_TYPE_VIS/_LIBCPP_HIDE_FROM_ABI/
- Refactor the std-format-spec parser. Since the `parser_no_` classes are a kind of useless dummy they can be removed. Due to this change several tests no longer that useful, they are removed.
- Test with designated initializers to improve readability of the tests. When this passes the CI I want to improve more of the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103368/new/

https://reviews.llvm.org/D103368

Files:
  libcxx/docs/Status/Cxx20Issues.csv
  libcxx/docs/Status/Cxx20Papers.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__format/formatter.h
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/include/format
  libcxx/include/module.modulemap
  libcxx/test/libcxx/diagnostics/detail.headers/format/parser_std_format_spec.module.verify.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/concepts_precision.h
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_integral.pass.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string.pass.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/test_exception.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103368.362991.patch
Type: text/x-patch
Size: 64786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210730/f344ac38/attachment-0001.bin>


More information about the libcxx-commits mailing list