[libcxx-commits] [PATCH] D105932: [libcxx][modules] protects users from relying on libc++ detail headers (1/n)

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/utils/CMakeLists.txt:16
+    COMMAND "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/utils/generate_private_header_tests.py"
+    COMMENT "Generates tests for ensuring detail headers are private")
+
----------------
ldionne wrote:
> ldionne wrote:
> > When you commit, please change this `COMMENT` to the imperative, like the others above.
> This was never done. Please make sure you read the comments when you get a LGTM, often I request changes but still give the green check mark to avoid stalling the patch on something trivial.
> 
> In this case it's really not a big deal, but ideally this wouldn't happen with more important comments. I'll make this change as a NFC.
Sorry, I clearly missed this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105932/new/

https://reviews.llvm.org/D105932