[libcxx-commits] [PATCH] D107066: [libc++] TEST DO NOT REVIEW

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 29 08:20:47 PDT 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/include/__config:851-856
 #if !defined(__cpp_concepts) || __cpp_concepts < 201907L
 #define _LIBCPP_HAS_NO_CONCEPTS
+#if _LIBCPP_STD_VER > 17
+#error "Platform doesn't support concepts"
+#endif
 #endif
----------------
I think a quicker and dirtier (but more accurate-to-real-life) method of testing this would have been to just unconditionally `#undef _LIBCPP_HAS_NO_CONCEPTS` and then see what breaks. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107066/new/

https://reviews.llvm.org/D107066



More information about the libcxx-commits mailing list