[libcxx-commits] [PATCH] D63744: In the libc++ unstable ABI, use [[no_unique_address]] instead of __compressed_pair when available.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D63744#2911574 <https://reviews.llvm.org/D63744#2911574>, @ldionne wrote:

> We now support only compilers that support `[[no_unique_address]]`.

I just noticed our Windows build bots don't support it.
https://buildkite.com/organizations/llvm-project/pipelines/libcxx-ci/builds/4579/jobs/5b2eb7ca-c775-4418-84f2-989e6ba3016e/raw_log

  -- The CXX compiler identification is Clang 12.0.0 with MSVC-like command-line
  -- The C compiler identification is Clang 12.0.0 with MSVC-like command-line

...

  C:/ws/w32-1/llvm-project/libcxx-ci/build/windows-dll/include/c++/v1\__iterator/counted_iterator.h(69,5): warning: unknown attribute 'no_unique_address' ignored [-Wunknown-attributes]
    [[no_unique_address]] _Iter __current_ = _Iter();
      ^~~~~~~~~~~~~~~~~
  1 warning generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63744/new/

https://reviews.llvm.org/D63744