[libcxx-commits] [PATCH] D106827: [libc++] Implement the resolutions for LWG3506 and LWG3522.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 28 18:20:10 PDT 2021


Quuxplusone closed this revision.
Quuxplusone added a comment.

Landed as part of  rG3894a8a4768f <https://reviews.llvm.org/rG3894a8a4768fd6fa9bf18303a0db1687c7c687b3>



================
Comment at: libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.cons/ctor_iter_constraint.compile.pass.cpp:18
+#include <type_traits>
+#include <vector>
+
----------------
ldionne wrote:
> You're missing tests for some of the constructors you modified, aren't you?
Yes; initially this was just a sanity-check to make sure that e.g.
`std::priority_queue<int> pq = {1,2}; // or maybe more ints`
didn't compile, even though it would compile fine for `std::vector`.
But adding the other signatures is easy, so done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106827/new/

https://reviews.llvm.org/D106827



More information about the libcxx-commits mailing list