[libcxx-commits] [PATCH] D106798: [libc++] [test] Add support for `ADDITIONAL_COMPILE_FLAGS_IF_SUPPORTED` directive.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 28 13:32:48 PDT 2021


ldionne added a comment.

In D106798#2911091 <https://reviews.llvm.org/D106798#2911091>, @curdeius wrote:

> In D106798#2910503 <https://reviews.llvm.org/D106798#2910503>, @ldionne wrote:
>
>> In D106798#2904406 <https://reviews.llvm.org/D106798#2904406>, @curdeius wrote:
>>
>>> @ldionne, is this acceptable or is it too hackish?
>>
>> So this is to add `-fconstexpr-steps=N`, correct? Clang supports that flag, GCC doesn't. Does GCC have a sufficiently large number of constexpr steps by default?
>
> Exactly. GCC is okay by default.

That would just be side-stepping the problem, but perhaps that means that Clang's default limit on constexpr steps is too low? What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106798/new/

https://reviews.llvm.org/D106798



More information about the libcxx-commits mailing list