[libcxx-commits] [PATCH] D106824: [libc++] Implement the resolution of LWG3506 in all language modes.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/queue:554
+
+#ifndef _LIBCPP_CXX03_LANG
+    template <class _InputIter, class _Alloc, class = _EnableIf<__is_cpp17_input_iterator<_InputIter>::value> >
----------------
Quuxplusone wrote:
> ldionne wrote:
> > Doesn't this work even in C++03 mode with the rvalue references extension?
> Yes, but I haven't been reckless enough yet to break our historical tradition that guards all actual container move-constructors and move-assignments under `_LIBCPP_CXX03_LANG`. I think we should break those all at once.
> 
> Note particularly the `priority_queue(const Comp&, Container&&, const Alloc&)` on line 528, which is already guarded like this.
Oh, thanks, I had not realized there was such a tradition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106824/new/

https://reviews.llvm.org/D106824