[libcxx-commits] [PATCH] D106923: [libcxx][ranges] Add `views::counted` CPO.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 3 inline comments as done.
zoecarver added inline comments.


================
Comment at: libcxx/test/std/ranges/range.adaptors/range.counted/counted.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
ldionne wrote:
> We need to test that `views::counted` is a CPO, see http://eel.is/c++draft/customization.point.object.
Added a test for semiregular. Are there other tests you want? Maybe noexcept tests? 


================
Comment at: libcxx/test/std/ranges/range.adaptors/range.counted/counted.pass.cpp:73
+    }
+  }
+
----------------
ldionne wrote:
> Can you also add a test with a `forward_iterator`?
Good idea. But I don't think forward iterator tests that much new stuff, so I added tests for `cpp20_input_iterator` and `output_iterator`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106923/new/

https://reviews.llvm.org/D106923