[libcxx-commits] [PATCH] D105910: [SystemZ][z/OS][libcxx] Mark tests that require runtime linking as unsupported on z/OS

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.dtor/dtor.pass.cpp:48
     // operator for calls within the libc++ DLL.
     TEST_NOT_WIN32_DLL(assert(globalMemCounter.checkDeleteArrayCalledEq(1)));
 
----------------
mstorsjo wrote:
> Here's an example on how this aspect only is waived in the Windows/DLL configuration.
Perhaps the macro's sense could be flipped, something like
```
ASSERT_VIA_OVERRIDDEN_NEW(globalMemCounter.checkDeleteArrayCalledEq(1));
```
similar to our existing `ASSERT_NOEXCEPT` and `ASSERT_SAME_TYPE` testing macros. Then, on platforms that support overridden `new` and `delete` operators, that macro would expand to `assert`; and on other platforms (Win32, z/OS) it would expand to a no-op.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105910/new/

https://reviews.llvm.org/D105910