[libcxx-commits] [PATCH] D103379: [libc++][format] Add a CMake Unicode option.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 28 09:35:46 PDT 2021


ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/CMakeLists.txt:122-125
+  embedded). When Unicode is not supported, the <format> header will use a
+  different width estimation algorithm. Instead of using Unicode based
+  estimations it will assume every input character will result in one output
+  character with a width of one column." ON)
----------------
I would not mention the special behavior of `<format>` specifically, since eventually there will be more that depends on this option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103379/new/

https://reviews.llvm.org/D103379



More information about the libcxx-commits mailing list