[libcxx-commits] [PATCH] D106798: [libc++] [test] Add support for `ADDITIONAL_COMPILE_FLAGS_IF_SUPPORTED` directive.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 28 08:44:36 PDT 2021


ldionne added a comment.

In D106798#2904406 <https://reviews.llvm.org/D106798#2904406>, @curdeius wrote:

> @ldionne, is this acceptable or is it too hackish?

It's a bit hackish IMO. I'm trying to think of better solutions. To be sure, importing `dsl.py` into `format.py` isn't much worse than what we do for `_supportsVerify`.

So this is to add `-fconstexpr-steps=N`, correct? Clang supports that flag, GCC doesn't. Does GCC have a sufficiently large number of constexpr steps by default?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106798/new/

https://reviews.llvm.org/D106798



More information about the libcxx-commits mailing list