[libcxx-commits] [PATCH] D106848: [libcxx] Don't define exception types with -fno-exceptions

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D106848#2907997 <https://reviews.llvm.org/D106848#2907997>, @phosek wrote:

> In D106848#2907399 <https://reviews.llvm.org/D106848#2907399>, @ldionne wrote:
>
>> I would like to avoid providing a different API for when exceptions are enabled vs disabled.
>>
>> Do you guys know what the rationale is for the VC runtime not to provide `std::exception`? I think we should try to align with them. My ideal resolution would simply be that the VC runtime provides the `std::exception` class even when `-fno-exceptions` is used, since that's what all other platforms do.
>
> Would D103947 <https://reviews.llvm.org/D103947> be a more acceptable solution? I don't know why VC runtime doesn't provide `std::exception` but even if we can convince Microsoft to change their approach, it's going to take years for that change to roll out so that strategy is not feasible for us since we would like to start using libc++ on Windows now.

Yeah, my initial reaction is that D103947 <https://reviews.llvm.org/D103947> is more in line with what we do in libc++ on other platforms, so we should go with that (after addressing some issues with that patch). But let's keep discussing on D103947 <https://reviews.llvm.org/D103947> -- I have little context on Windows so I might be asking for silly things without knowing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106848/new/

https://reviews.llvm.org/D106848