[libcxx-commits] [PATCH] D106935: [libc++][nfc] Improve error diagnostics.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

The error message for disabled filesystem and locale support is now done
in the same fashion as ranges and format in D106763 <https://reviews.llvm.org/D106763>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106935

Files:
  libcxx/include/filesystem
  libcxx/include/locale.h


Index: libcxx/include/locale.h
===================================================================
--- libcxx/include/locale.h
+++ libcxx/include/locale.h
@@ -36,7 +36,8 @@
 #include <__config>
 
 #if defined(_LIBCPP_HAS_NO_LOCALIZATION)
-#   error "Localization is not supported by this configuration of libc++"
+#error                                                                                                                 \
+    "The Localization library is not supported since libc++ has been configured with LIBCXX_ENABLE_LOCALIZATION disabled"
 #endif
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
Index: libcxx/include/filesystem
===================================================================
--- libcxx/include/filesystem
+++ libcxx/include/filesystem
@@ -253,7 +253,7 @@
 #endif
 
 #if defined(_LIBCPP_HAS_NO_FILESYSTEM_LIBRARY)
-# error "The Filesystem library is not supported by this configuration of libc++"
+# error "The Filesystem library is not supported since libc++ has been configured with LIBCXX_ENABLE_FILESYSTEM disabled"
 #endif
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106935.362288.patch
Type: text/x-patch
Size: 1125 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210728/ddb0ca44/attachment.bin>