[libcxx-commits] [PATCH] D105968: [libunwind][CET] Support exception handling stack unwind in CET environment

[H.J Lu via Phabricator via libcxx-commits]

hjl.tools added inline comments.


================
Comment at: libunwind/src/UnwindLevel1.c:42
+    _LIBUNWIND_POP_CET_SSP(1);                                                 \
+    __libunwind_cet_jumpto((cursor), (frames_skipped));                        \
+  } while (0)
----------------
xiongji90 wrote:
> hjl.tools wrote:
> > Why is this needed?  Can you unwind the shadow stack and jump to the landing pad as usual?
> Hi, @hjl.tools 
> I have updated the patch to remove some unnecessary code, could you help review again?
> Thanks very much.
__unw_phase2_resume looks quite fragile.   Can you call the function pointer,  cetJumpAddress, in C directly?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105968/new/

https://reviews.llvm.org/D105968