[libcxx-commits] [PATCH] D106763: [libc++][RFC] Disable incomplete library features.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D106763#2908310 <https://reviews.llvm.org/D106763#2908310>, @Quuxplusone wrote:

> FWIW, my general reaction is that this patch does more harm (to end-users) than good.

How so? If we don't do something like this, we'll let users use incomplete and unstable features, and then we'll break them in the future. I don't see how that's acceptable?

> Consider that `__has_include(<format>)` will now return the "wrong" value; it would be better and simpler if you could just figure out a way to stop the build system from installing that header in `include/c++/v1/` at all.

Honestly, using `__has_include` to check for features is already broken enough as it is, I don't think this makes it any worse. People need to learn that they can't use it that way, period.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106763/new/

https://reviews.llvm.org/D106763