[libcxx-commits] [PATCH] D106763: [libc++][RFC] Disable incomplete library features.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:402
+
+  PLACEHOLDER
 
----------------
ldionne wrote:
> Mordante wrote:
> > Mordante wrote:
> > > Update documentation.
> > @ldionne Is it intended these options are documented? There seem to be quite some missing options. For example `LIBCXX_ENABLE_RANDOM_DEVICE` and `LIBCXX_ENABLE_LOCALIZATION`
> Oh yeah, the documentation is not up to date in that respect. I'm actually thinking that it's quite bad that there's so much duplication (here and in the `CMakeLists.txt`). Since this is aimed at vendors, perhaps we could have a single copy of those options in the `CMakeLists.txt` and have the documentation point to that? If we grouped configure-time options together, it would make them discoverable. Just a thought.
I agree it would be nice if there was an automatic way to convert the CMake options to restructured text.


================
Comment at: libcxx/include/format:64
+#if defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)
+# error "The Format library is not supported by this configuration of libc++"
+#endif
----------------
ldionne wrote:
> Maybe this should say something like `The Format library is not complete and stable yet, so this configuration of libc++ does not allow its usage.`. Or anything else that explains a bit _why_ it's not supported (otherwise users tend to be angry).
I'm not objecting against making the text a bit more verbose. I just looked at what similar code did. I'll make a separate patch to improve these places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106763/new/

https://reviews.llvm.org/D106763