[libcxx-commits] [PATCH] D104328: [libc++] Always build libc++ and libc++abi with -fPIC

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

In D104328#2905866 <https://reviews.llvm.org/D104328#2905866>, @MaskRay wrote:

> Some obscure architectures don't support PIC, but none is supported by libunwind/libc++/libc++abi.
>
> Is the change for `-DCMAKE_POSITION_INDEPENDENT_CODE=off -DLLVM_ENABLE_PIC=off` builds?
> Note that LLVM_ENABLE_PIC is on by default => it adds -fPIC despite -DPOSITION_INDEPENDENT_CODE=off ...
>
> So we need information from users why their `LLVM_ENABLE_PIC` is somehow off.
> Do they explicitly set it to off?
>
> If both CMAKE_POSITION_INDEPENDENT_CODE and LLVM_ENABLE_PIC are set to off, do we expect that libLLVM*.a can be linked into a shared object?

This change is exclusively for the runtimes, i.e. `libunwind`, `libc++abi` and `libc++`. It doesn't have any impact on `libLLVM*.a` & friends.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104328/new/

https://reviews.llvm.org/D104328