[libcxx-commits] [PATCH] D106840: [libcxx][ranges] Add `std::ranges::single_view`.

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 27 09:29:29 PDT 2021


cjdb added a comment.

Nearly there!



================
Comment at: libcxx/test/std/ranges/range.factories/range.single.view/view_conformance.compile.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Please rename file to match the other range concept conformance tests.


================
Comment at: libcxx/test/std/ranges/range.factories/range.single.view/view_conformance.compile.pass.cpp:25
+static_assert(std::ranges::range<std::ranges::empty_view<Empty>>);
+static_assert(std::ranges::range<const std::ranges::empty_view<Empty>>);
+static_assert(std::ranges::view<std::ranges::empty_view<Empty>>);
----------------
This is a test for `single_view`, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106840/new/

https://reviews.llvm.org/D106840



More information about the libcxx-commits mailing list