[libcxx-commits] [PATCH] D106801: [libc++] [c++2b] [P2166] Prohibit string and string_view construction from nullptr.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but please remove `main()`s!



================
Comment at: libcxx/test/std/strings/string.view/string.view.cons/nullptr.compile.pass.cpp:22
+
+int main(int, char**) { return 0; }
----------------
You don't need to define a `main()` for `compile.pass.cpp` tests. Not defining a `main` makes it clear that the test was never intended to be run. Applies above too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106801/new/

https://reviews.llvm.org/D106801