[libcxx-commits] [PATCH] D106763: [libc++][RFC] Disable incomplete library features.
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jul 27 03:36:59 PDT 2021
Mordante added a comment.
In D106763#2906698 <https://reviews.llvm.org/D106763#2906698>, @Mordante wrote:
>> 4. Set `set(LIBCXX_ENABLE_INCOMPLETE_FEATURES OFF CACHE BOOL "")` in `Apple.cmake`.
>
> I prefer to have some Apple CI bots to override this default. That way we can validate whether the feature would work on Apple. Otherwise when we flip the switch we get all Apple build issues at the same time. I was thinking about using `MacOS x86_64` and `MacOS arm64`. WDYT?
Based on the build failures I got I had a look at the configuration and it actually seems these two nodes already exactly do that.
So you can ignore this comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106763/new/
https://reviews.llvm.org/D106763
More information about the libcxx-commits
mailing list