[libcxx-commits] [PATCH] D106107: [libc++][modularisation] Split <compare> into internal headers

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.

One final nit, then ship it!
(Assuming you don't need someone to land this for you. But if you do, please ping me and I can do it.)



================
Comment at: libcxx/include/module.modulemap:363-364
+    module __compare {
+      module ordering                   { private header "__compare/ordering.h"                   }
+      module common_comparison_category { private header "__compare/common_comparison_category.h" }
+    }
----------------
These two still need alphabetization between the two of them (i.e., switch their order).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106107/new/

https://reviews.llvm.org/D106107