[libcxx-commits] [PATCH] D106107: [libc++][modularisation] Split <compare> into internal headers

[Ruslan Arutyunyan via Phabricator via libcxx-commits]

rarutyun marked 6 inline comments as done.
rarutyun added inline comments.


================
Comment at: libcxx/include/__compare/common_comparison_category.h:9-10
+
+#ifndef _LIBCPP___COMMON_COMPARISON_CATEGORY_H
+#define _LIBCPP___COMMON_COMPARISON_CATEGORY_H
+
----------------
Quuxplusone wrote:
> I think our style would make this `_LIBCPP___COMPARE_COMMON_COMPARISON_CATEGORY_H` — please check some other nested-directory files, and then change it here if I'm right.
Yes, you are right. I did it for `ordering` header but for some reason prefix was missed for this file


================
Comment at: libcxx/include/module.modulemap:359-360
+    module __compare {
+      module ordering                   { private header "__compare/ordering.h"                   }
+      module common_comparison_category { private header "__compare/common_comparison_category.h" }
+    }
----------------
Quuxplusone wrote:
> a-z plz
Actually I've found another mistake that is more important. `compare module was already there and I needed to just add private headers. Now it's done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106107/new/

https://reviews.llvm.org/D106107