[libcxx-commits] [PATCH] D106824: [libc++] Implement the resolution of LWG3506 in all language modes.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/queue:537
 
+    template <class _InputIter, class _Alloc, class = _EnableIf<__is_cpp17_input_iterator<_InputIter>::value> >
+        _LIBCPP_INLINE_VISIBILITY
----------------
ldionne wrote:
> I'm not sure I understand why we're constraining those constructors with `is_cpp17_input_iterator`?
> 
> I understand it's just generally a bad idea to have unconstrained template parameters, but that seems to be what the spec has?
Never mind this, I just saw your other patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106824/new/

https://reviews.llvm.org/D106824