[libcxx-commits] [PATCH] D106107: [libc++][modularisation] Split <compare> into internal headers

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/include/compare:133-134
 
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
+
----------------
Quuxplusone wrote:
> Is this needed now for some reason? (Historically we seem to have put `__undef_macros` only in files that actually use `min` or `max` as identifiers. If something breaks without these lines, it'd be nice to say in your commit message what it is; and if nothing breaks without these lines, then //arguably// they shouldn't be here. Although I'm not inclined to //actually// object.)
This maaaaay have indirectly been my doing. I used to include `<__undef_macros>` in all my headers before I understood its purpose. I think since then it's just been included in everything by accident at this point. I agree we should remove it, and we should probably action some mass-cleanup in the near future (since I'm apparently taking responsibility for the trend, it makes sense for me to do it).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106107/new/

https://reviews.llvm.org/D106107