[libcxx-commits] [PATCH] D106107: [libc++][modularisation] Split <compare> into internal headers

Mon Jul 26 12:16:40 PDT 2021

rarutyun added a comment.

In D106107#2881766 <https://reviews.llvm.org/D106107#2881766>, @cjdb wrote:

> This should be mostly ready to go (I'm a bit surprised we only need two headers). Two bits of feedback.
>
> 1. **Blocking:** Please add these to the module map. The `ranges.__ranges` submodule should give you guidance on how to make the `compare.__compare` submodule. I'll LGTM once this is done.
> 2. Non-blocking: I'd appreciate it if you could change `[NFC]` in your commit summary to `[modularisation]`.

Done. Please check if everything correct

================
Comment at: libcxx/include/__compare/ordering.h:9
+
+#ifndef _LIBCPP___COMPARE_ORDERING_H
+#define _LIBCPP___COMPARE_ORDERING_H
----------------
I don't see the reason to create separate header for each ordering, but if you do I can change that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106107/new/

https://reviews.llvm.org/D106107